MongoDB | 2611937

Info

The test arbiter_always_has_latest_fcv.js is not correctly testing the behavior of arbiter FCV. It tries to set the binVersion to a lower value (which is a no-op, see comment below), and then check the FCV of the arbiter. Starting a cluster on an older binary version should cause the arbiter FCV to match the binary, not whatever kLatest is. We should actually be just modifying the FCV value via setFCV instead of modifying the binary version. In fact, the reason this test did not fail previously is because the `binVersion` option specified in the replica set test is invalid, as `nodeOpts` is not recognized by ReplSetTest. This should actually be `nodeOptions`, as shown by this example. As a result, this test was running the same test multiple times (checking the arbiter FCV of a cluster on latest binary and FCV). This is the only occurrence in the codebase where we use nodeOpts to try to set the binary version to a non-latest binary.

Top User Comments

xgen-internal-githook commented on Mon, 18 Mar 2024 20:06:55 +0000: Author: {'name': 'Ali Mir', 'email': 'ali.mir@mongodb.com', 'username': 'ali-mir'} Message: SERVER-88136 Fix arbiter_always_has_latest_fcv.js test to correctly test arbiter FCV behavior (#20108) GitOrigin-RevId: 9884a11dc2401e62f8d7bb10f219f7e7d5534f36 Branch: master https://github.com/mongodb/mongo/commit/83dac6f992955535218eb30d21eb938df5531d58

Steps to Reproduce