Operational Defect Database

BugZero found this defect 2513 days ago.

MongoDB | 372107

[SERVER-28691] warning C4373: 'mongo::Collection::aboutToDeleteCapped': virtual function overrides 'mongo::CappedCallback::aboutToDeleteCapped'

Last update date:

12/6/2017

Affected products:

MongoDB Server

Affected releases:

No affected releases provided.

Fixed releases:

3.5.7

Description:

Info

The following warning exists in collection.h: E:\workspace\mongo\src\mongo/db/catalog/collection.h(726): warning C4373: 'mongo::Collection::aboutToDeleteCapped': virtual function overrides 'mongo::CappedCallback::aboutToDeleteCapped', previous versions of the compiler did not override when parameters only differed by const/vol atile qualifiers E:\workspace\mongo\src\mongo/db/storage/capped_callback.h(53): note: see declaration of 'mongo::CappedCallback::aboutToDeleteCapped' I believe it is not necessary to have aboutToDeleteCapped in the Collection class.

Top User Comments

xgen-internal-githook commented on Thu, 20 Apr 2017 20:38:16 +0000: Author: {u'username': u'adamlsd', u'name': u'ADAM David Alan Martin', u'email': u'adam.martin@10gen.com'} Message: SERVER-28691 Disable MSVC warning C4373 The MSVC compiler has warnings which alert users that the behavior of the compiler has changed. In the case of C4383, the compiler used to have non-conforming behavior to C++98. At some point this behavior was fixed. MongoDB's code base should not have any code which would be adversely affected by this change, as the code is also compiled on platforms where the native compiler is conformant to the standard in this point. Therefore it should be safe to disable this warning. The specific warning cautions that a derived class's inline definition of a virtual function will now override a parent's implementation, where formerly it would not. This would happen when the derived class's implementation specified at least one of the parameters `const` (in such a way that the actual signature of the function isn't changed). MSVC incorrectly determines that if there are two functions that differ only in a non-observable `const` specifier, then they would have different signatures, in many circumstances. This would mean that the compiler resorts to treating such functions as overloads. The compiler now behaves correctly for the case of override in a derived class; however, it issues a warning. The warning is irrelevant to us. Branch: master https://github.com/mongodb/mongo/commit/4d6ac4793f023dfc7b393068ee14f6425fe7e3d2 kaloian.manassiev commented on Fri, 7 Apr 2017 19:54:24 +0000: adam.martin, I believe this showed up after your commits to cleanup library dependencies.

Additional Resources / Links

Share:

BugZero Risk Score

Coming soon

Status

Closed

Have you been affected by this bug?

cost-cta-background

Do you know how much operational outages are costing you?

Understand the cost to your business and how BugZero can help you reduce those costs.

Discussion

Login to read and write comments.

Have you ever...

had your data corrupted from a

VMware

bug?

Search:

...