Operational Defect Database

BugZero found this defect 2478 days ago.

MongoDB | 383499

[SERVER-29195] Some JS comments need their text reflowed to 100 characters after clang-format

Last update date:

9/27/2018

Affected products:

MongoDB Server

Affected releases:

No affected releases provided.

Fixed releases:

No fixed releases provided.

Description:

Info

In the commit for SERVER-22469, C-style comments rewrapped correctly, but C++-style comments came out looking like (e.g. db.js): // We have special handling for the 'flags' field, and provide sugar for specific flags. If // the // user specifies any flags we send the field in the command. Otherwise, we leave it blank // and // use the server's defaults. and //////////////////////////////////////////////////////////////////////////////////////////////////// //////////////////////////// Security shell helpers below ///////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////////////////////////

Top User Comments

max.hirschhorn@10gen.com commented on Tue, 16 May 2017 14:41:00 +0000: When clang-format wraps multiple lines that are over 100 characters onto separate lines, each wrapped at 100 characters. This behavior was known and was something that Mark worked around in SERVER-18978. We can try and use a script similar to find . -regextype posix-egrep -regex ".*\.(cpp|h)" | grep -v rlp_decls | xargs -I{} grep -H --color '.\{101\}' {} | wc -l to identify any other lines that should be reflowed.

Additional Resources / Links

Share:

BugZero Risk Score

Coming soon

Status

Closed

Have you been affected by this bug?

cost-cta-background

Do you know how much operational outages are costing you?

Understand the cost to your business and how BugZero can help you reduce those costs.

Discussion

Login to read and write comments.

Have you ever...

had your data corrupted from a

VMware

bug?

Search:

...